golang/go

x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit

Open

#24,946 opened on Apr 19, 2018

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In https://golang.org/cl/99337 a file using CRLF instead of LF line endings was added. When using git-codereview to send CLs, there is a gofmt check which prevents this. But it seems there is no corresponding check when sending CLs via Github PRs.

It would be nice to run the gofmt check also for PRs submitted via Github.

/cc @bradfitz @andybons

Contributor guide

Research direction
Investigate the current gerritbot code to understand how it processes GitHub PRs. Add a gofmt check step before pushing to Gerrit, similar to the check in git codereview. Ensure the check runs on all changed files and fails the PR if gofmt reports any issues.
Tech stack
go
Domain
devops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60