golang/go

x/build/maintner: growing files are not cleaned up

Open

#25,460 opened on May 19, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When the full file is downloaded, the corresponding growing file is not removed, so over time growing files accumulate. For example this is my cache directory at the moment:

[...]
0033.7b5b6f92e2eecdbfcfb06d7ed7a4f95f66092b2bb3693f41407bb546.mutlog
0034.435067e2842b0a7363a09a259e5aa1a2006787d95fae3a14a33b79b2.mutlog
0034.growing.mutlog
0035.f59248bfa6248f1cd081601c2d0331c97ecfd7807c3a4805d8fb65a8.mutlog
0035.growing.mutlog
0036.growing.mutlog

/cc @bradfitz

Contributor guide

Research direction
Trace the download handler in maintner and add file removal logic for the growing file after full file download completes.
Tech stack
go
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70