golang/go

x/net/http2: verify that net/http.Server.SetKeepAlivesEnabled(false) shuts down HTTP/2 server

Open

#26,303 opened on Jul 9, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Per https://github.com/golang/go/issues/20239#issuecomment-402199944 and its immediate reply, it seems that https://go-review.googlesource.com/c/net/+/43230 might've broken net/http.Server.SetKeepAlivesEnabled(false) shutting down HTTP/2 server connections.

I guess there's no test for it.

/cc @tombergan @pam4

Contributor guide

Research direction
Write a test for net/http.Server.SetKeepAlivesEnabled(false) for HTTP/2 and trace the connection shutdown path.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50