golang/go

x/tools/present: fix rendering on mobile

Open

#27,026 opened on Aug 16, 2018

View on GitHub
 (0 comments) (31 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixToolshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Trying to follow a presentation on a mobile device is currently very difficult. Some of the issues include:

  • Scrolling left or right sometimes doesn't move one slide; rather, it scrolls through the visible horizontal slides
  • The screens tend to be tall, meaning that the text is too small by default.
  • Trying to zoom in our out easily breaks the UI; one can end up with slides that are cut off.

Below is a screenshot I took after zooming in and out on a presentation of mine.

My HTML/JS skills are limited, so I don't know if this would be a major rework for mobile, or just some tweaking to have it behave better on small/tall screens.

Contributor guide

Research direction
Inspect the mobile rendering of the present tool by running it locally and testing on a mobile viewport. Look at the generated HTML and CSS files in the present package (x/tools/present) to identify issues with slide scrolling and zoom. Consider using CSS viewport units or media queries for responsive design.
Tech stack
gojavascriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60