golang/go

x/build/maintner: GitHub issue events are not consistent with API values

Open

#29,396 opened on Dec 22, 2018

View on GitHub
 (27 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Moved from #28226…

There are some issues that have events missing within the maintner corpus. This makes it impossible to create an accurate milestone burndown chart where you want to query for the state of an issue at a particular time window.

A few examples of issues in maintner that have incomplete event lists:

=== Issue events for golang.org/issues/28559
             labeled	milestone:         	label:Testing
             labeled	milestone:         	label:help wanted
             labeled	milestone:         	label:OS-OpenBSD
             labeled	milestone:         	label:Builders
             labeled	milestone:         	label:NeedsInvestigation
          milestoned	milestone:   Go1.12	label:

It does not record the final “closed” event: https://api.github.com/repos/golang/go/issues/28559/events

=== Issue events for golang.org/issues/28306
           mentioned	milestone:         	label:
          subscribed	milestone:         	label:
           mentioned	milestone:         	label:
          subscribed	milestone:         	label:
            assigned	milestone:         	label:
             labeled	milestone:         	label:Documentation
             labeled	milestone:         	label:NeedsInvestigation
          milestoned	milestone:   Go1.12	label:
             renamed	milestone:         	label:

The above event log is missing a few milestone-related events: https://api.github.com/repos/golang/go/issues/28306/events

Contributor guide

Research direction
Compare the events recorded in maintner with those from the GitHub API for the mentioned issues. Identify which events are missing and trace the code path in build/maintner that fetches issue events.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60