golang/go

x/tools/gopls: improve suggestions in completion placeholders

Open

#31,548 opened on Apr 18, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
FeatureRequestgoplshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Context: #31547.

We should suggest in-scope identifiers of the matching type when adding placeholders for a function.

We would also need to develop some heuristics to determine which identifier to suggest, if there are multiple in scope. (Ideas: most recently declared, closest name to the one declared in the function signature.)

Contributor guide

Research direction
Examine the gopls completion code to understand how placeholders are inserted. Identify the mechanism for retrieving in scope variables and match types. Research heuristics like recency or name closeness.
Tech stack
go
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50