golang/go

x/build/cmd/gopherbot: should not consider backport requests inside backport issues

Open

#32,533 opened on Jun 10, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A backport issue should never itself be backported, so gopherbot should reject requests to backport inside such issues.

See https://github.com/golang/go/issues/32261#issuecomment-496157952 where it happened by accident and caused confusing backport-backport issues to be created.

Also happened in https://github.com/golang/go/issues/34881#issuecomment-541459267.

Contributor guide

Research direction
Inspect the gopherbot code in x/build/cmd/gopherbot to find where backport requests are processed. Add a check to ignore requests when the issue itself is a backport issue.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65