golang/go

x/crypto/ssh: test consistently runs out of memory on js-wasm builder

Open

#32,840 opened on Jun 28, 2019

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixOS-JSTestingarch-wasmhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The golang.org/x/crypto/ssh test consistently fails on the js-wasm builder with the error message runtime: out of memory: cannot allocate 8192-byte block.

Can the test be made to fit within the runtime on that architecture? If not, it should be skipped, instead of continuing to fail and potentially masking more serious problems.

CC @hanwen @neelance @FiloSottile

Contributor guide

Research direction
Investigate the memory usage of the ssh test on js wasm. Consider skipping the test with a build tag or reducing memory allocations.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70