golang/go

encoding/json: Unmarshal & json.(*Decoder).Token report different values for SyntaxError.Offset for the same input

Open

#34,543 opened on Sep 25, 2019

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

What did you do?

https://play.golang.org/p/zkVEGITpYIo

What did you expect to see?

The same Offset for the two error cases, as it is the same input.

What did you see instead?

Different Offset.

Contributor guide

Research direction
Compare the offset reporting logic in json.Unmarshal and json.(*Decoder).Token for SyntaxError to ensure they produce the same offset for identical invalid inputs.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65