golang/go

x/build/cmd/coordinator: add timeout to make.bash

Open

#35,364 opened on Nov 5, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It seems the build coordinator doesn't have a timeout on the make.bash phase?

This Mac builder is stuck in make.bash for over 4 hours:

darwin-amd64-10_14 rev 2566e21f; running; http://macstadium_host07b reverse peer macstadium_host07b/207.254.3.58:60202 for host type host-darwin-10_14, 4h48m28s ago
  2019-11-04T23:20:00Z checking_for_snapshot 
  2019-11-04T23:20:01Z finish_checking_for_snapshot after 377.4ms
  2019-11-04T23:20:01Z get_buildlet 
  2019-11-04T23:20:01Z wait_static_builder host-darwin-10_14
  2019-11-04T23:20:01Z finish_wait_static_builder after 0s; host-darwin-10_14
  2019-11-04T23:20:01Z clean_buildlet http://macstadium_host07b reverse peer macstadium_host07b/207.254.3.58:60202 for host type host-darwin-10_14
  2019-11-04T23:20:01Z finish_clean_buildlet after 32.1ms; http://macstadium_host07b reverse peer macstadium_host07b/207.254.3.58:60202 for host type host-darwin-10_14
  2019-11-04T23:20:01Z finish_get_buildlet after 276.1ms
  2019-11-04T23:20:01Z using_buildlet macstadium_host07b
  2019-11-04T23:20:01Z write_version_tar 
  2019-11-04T23:20:01Z get_source 
  2019-11-04T23:20:05Z finish_get_source after 3.9s
  2019-11-04T23:20:05Z write_go_src_tar 
  2019-11-04T23:20:11Z finish_write_go_src_tar after 6.16s
  2019-11-04T23:20:11Z make_and_test 
  2019-11-04T23:20:11Z make src/make.bash
 +17297.4s (now)

Contributor guide

Research direction
Look in the build coordinator code for where make.bash is executed and add a timeout around that call. Search for 'make.bash' in the golang/go repository, particularly in the cmd/coordinator directory.
Tech stack
go
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65