golang/go

x/build/cmd/gerritbot: sometimes fails to close PR after its imported CL is submitted

Open

#35,867 opened on Nov 27, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We should investigate why gerritbot didn't close a PR that was imported into Gerrit as a CL and submitted.

See https://github.com/golang/go/pull/35751#issuecomment-558859722 for more details.

Thanks @odeke-em for noticing and reporting.

Contributor guide

Research direction
Investigate the gerritbot handler for CL submission events and trace the logic that should close the associated PR. Check recent changes to the gerritbot code and the specific PR #35751 and CL 208318 for context.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75