golang/go

x/net/http2: test timeouts on js-wasm builder

Open

#36,088 opened on Dec 11, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationOS-JSarch-wasmhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

2019-12-09T16:08:50-c0dbc17/js-wasm has an interesting timeout failure.

It's not obvious to me whether it is due to a bug in the test, a bug in the js/wasm standard library, or a bug in x/net/http2 or one of its dependencies that happens to be exposed by the different goroutine scheduling on js/wasm.

The presence of a goroutine blocked in net.(*bufferedPipe).Read via crypto/tls makes me suspect a concurrency bug in either golang.org/x/net/http2 or crypto/tls, but admittedly that evidence is not compelling.

I also can't reliably determine how often this occurs or on what platforms because I can't fetch most of the x/net logs (#35515).

CC @bradfitz @FiloSottile @tombergan

Contributor guide

Research direction
Investigate the test timeout on js wasm builder. Look at the goroutine blocking in net.(*bufferedPipe).Read via crypto/tls. Determine if the bug is in x/net/http2, crypto/tls, or the js/wasm standard library. Reproduce the timeout and trace the concurrency path.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20