golang/go

cmd/go: mod why -m is not strict when parsing an import path

Open

#36,658 opened on Jan 20, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (19,008 forks)batch import
GoCommandNeedsFixhelp wantedmodules

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

What did you do?

In a project that depends on golang.org/x/tools/go/packages, I executed

go mod why -m golang.org/x/tools/

What did you expect to see?

go: malformed import path "golang.org/x/tools/": trailing slash

as it is done by go mod init.

What did you see instead?

# golang.org/x/tools/
(main module does not need module golang.org/x/tools/)

Contributor guide

Research direction
Inspect the parsing logic in the 'go mod why' command to see how it handles import paths and add validation for trailing slashes, similar to the validation in 'go mod init'.
Tech stack
go
Domain
backendclitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoUnderstanding of Go modules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65