golang/go

x/review/git-codereview: skip tests that require "gofmt" binary when it's not available

Open

#36,801 opened on Jan 27, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixTestinghelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://build.golang.org/log/36fc6a856500bd206f0f994b1565fb6badbe7034

aix-ppc64 at 6fbdfe48041c883a9f6d8c981a7205b7c327862a building review at f51a73253c4da005cfdf18a036e11185c04c8ce3
…
--- FAIL: TestGofmt (0.55s)
    gofmt_test.go:46: git-codereview gofmt -l
    util_test.go:323: died
        stdout:
        stderr:
        git-codereview: invoking gofmt: exec: "gofmt": executable file not found in $PATH
…

I'm not sure whether this should be resolved by adding gofmt to the builder's PATH, by updating the git-codereview tool to invoke go fmt instead, by updating the test to install that tool if not present, or by updating the test to skip those cases if the gofmt binary is not found.

This is technically a release-blocker via #11811, but seems pretty minor. (CC @dmitshur @cagedmantis @toothrot @trex58)

Contributor guide

Research direction
Look at the test file `gofmt test.go` and add a check using `exec.LookPath("gofmt")` to skip the test if `gofmt` is not found in PATH. See existing patterns in the repository for skipping tests when external tools are missing.
Tech stack
go
Domain
testingtooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80