golang/go

x/tools/gopls: add support for OnTypeFormatting

Open

#37,084 opened on Feb 6, 2020

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Go (19,008 forks)batch import
FeatureRequestToolsgoplshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Per https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_onTypeFormatting, add support for OnTypeFormatting.

@stamblerre I'll leave you to milestone.

cc @findleyr

FYI @leitzler

Contributor guide

Research direction
Study the LSP specification for textDocument onTypeFormatting and review existing formatting handlers in gopls (e.g., textDocument/formatting, textDocument/rangeFormatting). Implement the onTypeFormatting handler and register it in the gopls server.
Tech stack
go
Domain
backenddeveloper experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoLSP protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50