golang/go

x/build: add slowbots heuristics

Open

#37,454 opened on Feb 25, 2020

View on GitHub
 (4 comments) (4 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersFeatureRequestNeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Slowbots are awesome, but manual, and thus error-prone.

We could add some heuristics to automatically trigger appropriate slowbots. For example, any change that touches cmd/compile/internal/ssa/rewrite_ARCH.go should trigger slowbots for that arch (or set of arches). Similarly for any file named whatever_ARCH.s. Probably something similar for files named whatever_OS.go.

We could start small and improve heuristics over time. There'd be a few false positives, but probably few enough that it'd be worth it.

cc @bcmills @dmitshur

Contributor guide

Research direction
Examine the existing slowbot setup and identify file patterns that trigger slow tests. Propose heuristics mapping file changes to required slowbots.
Tech stack
go
Domain
build systemci cd
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoCI/CD pipelines
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30