golang/go

x/tools/gopls: use telemetry library to check if completion exceeded its timeout

Open

#38,277 opened on Apr 6, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (19,008 forks)batch import
Toolsgoplshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As part of debugging https://github.com/golang/go/issues/38269, we've been discussing how we can indicate in tests that completion failed because of a timeout instead of a genuine failure. We don't want to return an error in this case because we still want to return whatever completion items we were able to produce before the timeout. @findleyr suggested that we could use the telemetry library for this.

/cc @ianthehat

Contributor guide

Research direction
Examine the telemetry library in the Go repository and the gopls completion tests to understand how to integrate timeout detection without returning an error.
Tech stack
go
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45