golang/go

x/build/maintner: doesn't pick the same Change-Id line as Gerrit when a CL commit message contains more than one such line

Open

#45,213 opened on Mar 24, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In CL 301589 patch set 3, there were 2 Change-Id lines.

[...]
Change-Id: Ia979f971b9bf581b230d7d240ad4068e594eefe0
[...]
Change-Id: I5e1cd3357a5ae202a902060935b99fd1a821ba59

In that particular case, Gerrit uses the second one, while maintner picks the first one.

There's a TODO in the code:

// TODO: git footers are treated as multimaps. Account for this.

It's rare for a CL to have more than one Change-Id line with different IDs, so this doesn't come up often.

CC @golang/release.

Contributor guide

Research direction
Modify the footer parsing in maintner to take the last Change Id line instead of the first, matching Gerrit's behavior.
Tech stack
go
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70