golang/go

cmd/go: test with `-run /something` prints "no tests to run" inconsistently

Open

#48,851 opened on Oct 7, 2021

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
GoCommandNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When running a test with -run /subtest_name where no subtests match, it will print okay, even though no tests were run. Same is true if you use -run Test/subtest_name. If instead, you do -run TestNameInPackage/subtest_name (where TestNameInPackage is the name of a test in that package) it will print "[no tests to run]"

Example:

➜  go test archive/tar -run /nomatchinghere 
ok      archive/tar     0.145s
➜  go test archive/tar -run Test/nomatchinghere 
ok      archive/tar     0.164s
➜  go test archive/tar -run TestWrite/nomatchinghere
ok      archive/tar     0.138s [no tests to run]

It has a similar issue when -v is set

/cc @bcmills @jayconrod @matloob

Contributor guide

Research direction
Inspect the test matching logic in cmd/go/internal/test to understand why run /pattern prints 'ok' when no subtests match, but prints '[no tests to run]' when a specific test name is given.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75