golang/go

x/sys/windows: mkwinsyscall: Add support for DLLs with extensions other than .dll

Open

#58,337 opened on Feb 5, 2023

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationOS-Windowscompiler/runtimehelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

What did you do?

Some of the Windows system dynamic link library (DLL) files have extensions other than .dll. For example,

  • ActiveX Controls files with .ocx extension
  • Control Panel applets with .cpl extension
  • Device drivers with .drv extension

mkwinsyscall does not support generating the syscall wrappers for these DLLs with different extensions. The extension is always hard-coded to .dll in the generated code.

What did you expect to see?

What did you see instead?

Proposed solution

If the user specified the extension of the DLL in the //sys comment, use that extension instead of adding the .dll extension. Going back to the previous example, the user can specify the extension as .drv in the //sys comment.

Then, the generated code will be,

The code changes are fairly straightforward. I have working code that I can submit as a pull request if the proposal makes sense.

Contributor guide

Research direction
Inspect the mkwinsyscall code that hard codes the .dll extension when generating syscall wrappers. Modify it to respect the extension provided in the //sys comment, falling back to .dll if none is given. Ensure generated code uses NewLazySystemDLL with the correct DLL name.
Tech stack
go
Domain
backendbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoWindows syscall basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70