golang/go

x/mobile/bind: C functions in headers should not be PascalCase

Open

#58,480 opened on Feb 12, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
FeatureRequestNeedsInvestigationhelp wantedmobile

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

What did you do?

When using go bind ios in our project we are getting everything coming through as PascalCase. This is irritating because it's standard for methods and functions to be camelCase, classes to be PascalCase, and so on. But instead go bind ios seems to treat everything as PascalCase whether it's a class, function, method, variable, interface or anything else.

At a minimum go bind ios and go bind android should adopt best practices for casing.

What did you expect to see?

Classes: PascalCase, methods: camelCase, constants or enums: UPPERCASE, variables: camelCase.

What did you see instead?

Everything is PascalCase

Contributor guide

Research direction
Inspect the code generator in `x/mobile/bind` and find where identifiers are converted to PascalCase. Modify the naming logic to follow Go naming conventions for different constructs (types, functions, methods).
Tech stack
go
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75