golang/go

cmd/go: downloading dependencies stuck when git tag signature is enable with an interactive editor

Open

#63,758 opened on Oct 26, 2023

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
GoCommandNeedsInvestigationhelp wantedmodules

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

What did you do?

My terminal has EDITOR=nvim set. go mod download gets stuck once it calls git tag and git opens NeoVim in the background.

The solution was to do EDITOR= go mod download. Maybe the EDITOR variable should be cleared when calling git.

What did you expect to see?

The command should complete

What did you see instead?

Nothing, the program is stuck. Inspecting the process tree, I see this:

image

Contributor guide

Research direction
Search for places in the Go source where git commands are invoked, specifically in the module download code, and modify the environment to clear or ignore the EDITOR variable before executing git.
Tech stack
go
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85