golang/go

x/tools/go/analysis/passes/testinggoroutine: do not ignore calls in goroutines (false negative)

Open

#63,849 opened on Oct 31, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
AnalysisNeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

$ go vet -testinggoroutine some_test.go

func TestSomething(t *testing.T)
	go func() {
		helper(t)       // No warning :(
	}()
}

func helper(t *testing.T) {
        t.Helper()
	t.Fatal()
}

Contributor guide

Research direction
Investigate the testinggoroutine pass in go vet to understand why calls to helper(t) inside a goroutine are not flagged, and propose a fix to detect such cases.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75