golang/go

x/review/git-codereview: 'git sync' should say what happened

Open

#9,633 opened on Jan 19, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When git sync does a fast forward or rebase, it would be nice to know what it did.

Something like this:

$ git sync
Synced local branch 'foo' HEAD to d34db33f (17 new commits)
$ git sync
Local branch 'foo' HEAD at d34db33f (no new commits)

Contributor guide

Research direction
Find the source code for the 'git sync' command in the go review repository (x/review/git codereview). Locate where the sync operation occurs (fast forward or rebase) and add print statements that output the branch name, new HEAD hash, and number of new commits. Use the existing logging pattern in the codebase.
Tech stack
go
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80