grafana/mimir

Validate -blocks-storage.bucket-store.ignore-blocks-within when running in monolithic mode

Open

#2,675 opened on Aug 9, 2022

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Go (808 forks)auto 404
ease-of-usehacktoberfest

Repository metrics

Stars
 (5,181 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm seeing help requests from several people lowering -querier.query-store-after without changing -blocks-storage.bucket-store.ignore-blocks-within, causing some queries to fail with "consistency check failed" errors.

We should validate -blocks-storage.bucket-store.ignore-blocks-within setting to make sure it has been set to a value lower than -querier.query-store-after minus a delta (in jsonnet we used a 2h delta).

Unfortunately, -querier.query-store-after is set on the querier, while -blocks-storage.bucket-store.ignore-blocks-within is set on the store-gateway, so there's no reliable way to validate it when running in microservices mode. However, we could at least validate it when running monolithic mode.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.