grafana/mimir

Inject test license into ct install test of GEM

Open

#2,689 opened on Aug 10, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (808 forks)auto 404
good first issuehelmsquad/customertype/tests

Repository metrics

Stars
 (5,181 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe.

Currently we install GEM without license in CI: there are many logs saying:

level=warn ts=2022-08-02T07:40:01.681249292Z caller=manager.go:169 msg="unable to load local license" error="error parsing license token: square/go-jose: compact JWS format must have three parts"

This means that we cannot test some features of GEM even if we wanted to.

Describe the solution you'd like

  • store a test license as secret in github
  • let the common workflow take two parameters: the secret and values path where to inject it into the configuration (e.g. license.contents for GEM.
  • check that it works and logs are gone about invalid license

Describe alternatives you've considered

N/A

Additional context

N/A

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.