grafana/mimir

helm: promote autoscaling to stable

Open

#7,368 opened on Feb 12, 2024

View on GitHub
 (17 comments) (0 reactions) (1 assignee)Go (808 forks)auto 404
helmhelp wanted

Repository metrics

Stars
 (5,181 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/grafana/mimir/pull/7282 added autoscaling to Helm as an experimental feature. This issue is about remaining work in order to promote autoscaling to stable.

The goal of this issue is to promote existing autoscaling support stable. This includes (ruler-)querier, distributor, (ruler-)query-frontend, and ruler. It does not include store-gateways and ingesters.

Bugs

Docs/Migration procedure

Remote URL UX

  • Support a remote different from the metamonitoring setup https://github.com/grafana/mimir/pull/7392
  • Take the additional headers and auth from metamonitoring setup. Currently basic auth and extra headers are ignored.
  • Default to X-Scope-OrgID: metamonitoring if the config is already sending metrics to the same Mimir installation (the same way that metamonitoring computes it)
  • Add validation that is same mimir cluster is used, then metamonitoring is also enabled

Helm-jsonnet diffing

  • Add helm-jsonnet diffing so that the autoscaling configs don't get out of sync when we change one and forget to change the other. This is a matter of enabling autoscaling on select components in these two files and then making sure there are no differences between the rendered manifests. Minor differences can still be ignored via kustomiztions like this one

Make dashbaords compatible with helm-deployed KEDA objects

Contributor guide