gristlabs/grist-core

make limit on API request body size configurable

Open

#916 opened on Mar 27, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (168 forks)batch import
good first issue

Repository metrics

Stars
 (3,613 stars)
PR merge metrics
 (Avg merge 11d 9h) (47 merged PRs in 30d)

Description

There is a limit set on the maximum API request body size. That limit is currently hardcoded to 1mb (https://github.com/gristlabs/grist-help/pull/320#issuecomment-2021537352). It would be good to make this configurable, in the same way that related parameters like GRIST_MAX_UPLOAD_IMPORT_MB and GRIST_MAX_UPLOAD_ATTACHMENT_MB are.

Contributor guide

Research direction
Find the hardcoded 1MB limit in the codebase, likely in an API handler or middleware. Look for existing patterns like GRIST MAX UPLOAD IMPORT MB to implement a new environment variable, e.g., GRIST MAX API BODY MB, and add it to configuration.
Tech stack
typescript
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70