grpc-ecosystem/grpc-gateway

openapiv2.proto NULL conflict with c++ keyword

Open

#1,031 opened on Sep 4, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (2,250 forks)batch import
bughelp wanted

Repository metrics

Stars
 (16,971 stars)
PR merge metrics
 (Avg merge 8d 23h) (147 merged PRs in 30d)

Description

https://github.com/grpc-ecosystem/grpc-gateway/blob/3ad0fb96ecfdf73fa2eddb3de116ae98360dbb35/protoc-gen-swagger/options/openapiv2.proto#L218

compiled openapiv2.proto cpp file contains NULL, conflict with c++ keyword. Any suggestion on how to solve this?

Contributor guide

Research direction
Rename the field 'NULL' in openapiv2.proto to avoid C++ keyword conflict, e.g., 'NULL VALUE'. Then regenerate the C++ code and update any references.
Tech stack
gocpp
Domain
backendapibuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ProtobufC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60