grpc-ecosystem/grpc-gateway

registry: descriptor.Field.FieldMessage is never set

Open

#1,136 opened on Feb 17, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (2,250 forks)batch import
bughelp wanted

Repository metrics

Stars
 (16,971 stars)
PR merge metrics
 (Avg merge 8d 23h) (147 merged PRs in 30d)

Description

Hi! While fixing a bug in github.com/utrack/clay I've noticed that bindings' Body.FieldPath[].Target.FieldMessage is always nil.

I don't see any references to FieldMessage in grpc-gateway@v1.12.1, so I don't believe there are any bugs related to it, so it can be dropped.

However, the field itself looks useful and is worth to be populated IMO. I'll make a PR if you decide to keep it in the registry.

Contributor guide

Research direction
Examine how FieldMessage is supposed to be populated in the descriptor; check if it's used elsewhere; decide whether to populate it or remove the field.
Tech stack
go
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70