grpc-ecosystem/grpc-gateway

Support Enum Types in Path

Open

#322 opened on Mar 6, 2017

View on GitHub
 (2 comments) (8 reactions) (0 assignees)Go (2,250 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (16,971 stars)
PR merge metrics
 (Avg merge 8d 23h) (147 merged PRs in 30d)

Description

Having merged Enum support into the query parameters, would it be possible to now support Enum Types in the path as well? Currently this appears to be limited by https://github.com/grpc-ecosystem/grpc-gateway/blob/fdcb7eab2d6ed4919e83ddcef4f199c161611e1f/protoc-gen-grpc-gateway/descriptor/types.go#L293 not being implemented for Enum types.

Contributor guide

Research direction
Implement enum type handling in path parameter parsing by extending the descriptor type mapping in types.go.
Tech stack
gogrpc
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GogRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70