highlightjs/highlight.js

(themes) "faded" comments should be optional, not default.

Open

#3,483 opened on Feb 15, 2022

View on GitHub
 (10 comments) (1 reaction) (0 assignees)JavaScript (3,497 forks)batch import
enhancementgood first issuehelp welcometheme

Repository metrics

Stars
 (22,960 stars)
PR merge metrics
 (Avg merge 6m) (2 merged PRs in 30d)

Description

I think perhaps for accessibility that a pass over ALL the comment styles in all (1st party, not Base16) themes and pulling them up to a 3 or 4.5 contrast and then recommend that those who want the common "i can barely see the comments" look/feel should apply opacity of their desired choosing to hljs-comment. That way we equally support both accessibility and user choice.

I'm going to split this into a separate issue and add it to the v12 list.

Update: Definitely seems like we should first update the theme checker tool to use APCA.

Originally posted by @joshgoebel in https://github.com/highlightjs/highlight.js/issues/3482#issuecomment-1040565915

Contributor guide

Research direction
Examine how comment styles are defined across all first party themes, understand the APCA contrast algorithm, and propose a change to make faded comments optional while ensuring accessibility.
Tech stack
javascript
Domain
frontendaccessibility
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
CSSAccessibility
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65