ihhub/fheroes2

Hero screen, number of points for primary skill, the horizontal position of the number of points is shifted for Attack and Defense primary skills

Open

#1,683 opened on Sep 14, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (469 forks)auto 404
good first issuelow prioritypixel-precisionui

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

In fheroes2, the horizontal position of the number of points is shifted for Attack and Defense primary skills compared to the original game.

Edit 2021/01/25.

This is also the case for Spell Power and Knowledge.

Edit.

So I tested up to "11".

The number "4" is the only one that is not shifted (with the number "1"). For "10" and "11" the number "1" of the tens is shifted, not the number of the units, but it must also be taken into account that the spacing between the letters of the font is not the same as in the original game.

In original game:

Hero screen H2 10

In fheroes2:

Hero screen fh2 10

Open the two images in different tabs in your browser, enlarge the images and switch between the two tabs alternately. Heroes 2 first, fheroes2 second.

Primary skills position H2 01 Primary skills position fh2 01

Contributor guide

Research direction
Investigate the rendering of hero primary skill points in the hero screen, compare with original game alignment, and adjust horizontal position for Attack, Defense, Spell Power, and Knowledge numbers.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++game development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65