ihhub/fheroes2

Select game resolution window, position of elements

Open

#1,891 opened on Oct 3, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (469 forks)auto 404
good first issuehelp wantedlow prioritypixel-precisionui

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

  • The title is not centered horizontally in relation to the resolution frame.
  • Each resolution line is not centered horizontally with respect to the resolutions frame.
  • The vertical spacing between lines is not regular (19 pixels and 20 pixels from baseline of text to baseline of text).
  • The "OKAY" and "CANCEL" buttons are not the same horizontal distance from the edge of the window closest to the button.

In fheroes2 2045:

Select game resolution evil fh2 2045 02

Contributor guide

Research direction
Inspect the UI code for the resolution selection dialog (likely in 'src/fheroes2/game/') to find where positioning is defined. Adjust horizontal centering of title and resolution lines, fix vertical spacing to be consistent (e.g., 20px baseline), and ensure button margins are equal from window edges.
Tech stack
None
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70