ihhub/fheroes2

Musics and sounds, transition between musics and complet sounds

Open

#1,981 opened on Oct 12, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (469 forks)auto 404
audiohelp wanted

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

All over the game, whenever there is a transition between different musics, or when a music must be interrupted (for example at the end of a combat), there should be a fade in the sound (the sound level is attenuated until it is no longer heard) before switching to the other music and when the music needs to be stopped.

Also when a sound is played, it must be fully played before the next action is taken.

In fheroes2, for example during combat, when the last opposing creature is decimated, the creature's sound may not be fully played and may be cut off abruptly when the end of combat window is displayed. The end of combat window should only be displayed when all combat sounds have been fully played. The music of the combat is also cut off abruptly when the end of combat window is displayed.

Related issue: https://github.com/ihhub/fheroes2/issues/1979.

Contributor guide

Research direction
Look into the audio system code in the fheroes2 repository, specifically how music and sound effects are managed. Identify where music transitions occur (e.g., combat start/end) and check if there are fade functions. For sound completion, examine the event handling after combat to see if it waits for all sounds to finish.
Tech stack
None
Domain
game devdesktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70