import-js/eslint-plugin-import

regression: no-extraneous-dependencies when lint target file in a module sub-folder containing package.json

Open

#1,270 opened on Jan 25, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Using node@10.15.0 on OSX. Upgraded eslint-plugin-import from 2.14.0 to 2.15.0. Have a package.json that includes numerous dependencies of the form:

"xyz": "git+ssh://git@github.home.247-inc.net:platform/xyz.git#0.0.8",

When running eslint@5.12.1 I now get errors of the following form:

error 'xyz' should be listed in the project's dependencies. Run 'npm i -S xyz' to add it import/no-extraneous-dependencies

Reverting to 2.14.0, the errors are no longer reported.

Contributor guide

Research direction
Investigate the change between versions 2.14.0 and 2.15.0 that caused the no extraneous dependencies rule to incorrectly flag git+ssh dependencies. Check the rule's handling of package.json parsing and dependency resolution for git URLs.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70