jazzband/django-model-utils

FieldTracker for AbstractModel children is still not stable

Open

#382 opened on Aug 5, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (370 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (2,762 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Problem

I have found that AbstractModelTrackerTests is not quite correct. Since it inherited from FieldTrackerTestCase that just implements some extra assertions, there are no actual tests for this case.

Solution

I have fixed AbstractModelTrackerTests and it seems that some tests are failed for the case with models inherited from some AbstractModel with fields defined (like AbstractUser and its children)

#381 - pull request

Contributor guide

Research direction
Examine the failing tests in AbstractModelTrackerTests. Trace the FieldTracker logic for models that inherit from AbstractModel with fields. Check if the field tracking correctly handles the inherited fields and identify the cause of the instability.
Tech stack
pythondjango
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDjangopytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65