jeffreytse/zsh-vi-mode

Slow on 'J' in NORMAL mode

Open

#240 opened on Aug 30, 2023

View on GitHub
 (2 comments) (3 reactions) (1 assignee)Shell (147 forks)github user discovery
good first issue

Repository metrics

Stars
 (4,364 stars)
PR merge metrics
 (PR metrics pending)

Description

General information

  • Terminal program: iTerm.app 3.4.20 (xterm-256color)
  • Operating system: macOS 13.5.1 (22G90)
  • ZSH framework: starship 1.16.0
  • ZSH version: zsh 5.9 (x86_64-apple-darwin22.0)
  • ZVM version: zsh-vi-mode 0.10.0

Basic examination

  • I have read through the README page
  • I have the latest version of zsh-vi-mode
  • I have tested with another terminal program

Problem description

Using ZVM_VI_ESCAPE_BINDKEY=jj

Reproduction steps

  1. Press 'jj' to enter NORMAL mode
  2. Press 'k' a number of times to navigate back/up in the history
  3. Press 'j' to navigate down/forward in the history and notice a delay

Expected behavior

'j' should be as fast as 'k' It seems that in NORMAL mode there is a delay after pressing 'j' perhaps because it's waiting if 'j' is pressed again within a certain timeframe (ZVM_VI_ESCAPE_BINDKEY). I would think that this is only necessary in INSERT mode to escape it.

Contributor guide

Research direction
Investigate the ZVM VI ESCAPE BINDKEY mechanism in INSERT mode and how it affects NORMAL mode key waiting for 'j' after entering NORMAL mode. Look for timeout settings or key timeout handling in the plugin code.
Tech stack
shell
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ZSHGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60