jenkinsci/eiffel-broadcaster-plugin

Channel creations aren't checked for null

Open

#88 opened on Jan 5, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (14 forks)auto 404
buggood first issue

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

Jenkins and plugins versions report

N/A; bug exists in all environments.

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A; bug exists in all environments.

Reproduction steps

  1. Shut down the AMQP connection from the server side.
  2. Be extremely unlucky when you send the next event.

Expected Results

Clean reconnection after the disconnection.

Actual Results

An NPE when com.rabbitmq.client.Connection#createChannel returns null (which is legitimate and documented behavior):

https://github.com/jenkinsci/eiffel-broadcaster-plugin/blob/295b6b484d7979c1e4e2e830b2a426612d4d2ec6/src/main/java/com/axis/jenkins/plugins/eiffel/eiffelbroadcaster/MQConnection.java#L304-L312

This causes the message queue thread to die, and prior to v2.5.0 it wouldn't be able to recover either.

Anything else?

No response

Contributor guide

Research direction
Add a null check after calling createChannel at line 304, and handle null by logging and retrying or exiting gracefully.
Tech stack
java
Domain
backendci cd
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAMQP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75