jesseduffield/lazydocker

Use "docker compose" instead of "docker-compose"

Open

#371 opened on Oct 8, 2022

View on GitHub
 (6 comments) (3 reactions) (0 assignees)Go (1,612 forks)batch import
enhancementhacktoberfest

Repository metrics

Stars
 (51,040 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. Docker compose V2 is baked into the docker binary since April this year, and V1 is deprecated. You invoke V1 via docker-compose and you invoke V2 via docker compose.

At the moment, users can change their config to use docker compose instead of docker-compose (see here). The default value is set in the code here.

We need to do a couple things:

  1. Update all mentions of 'docker-compose' in the repo to now say 'docker compose'
  2. Add a section in the config doc to explain how to switch back to docker-compose

One thing worth thinking about is: should we have some code that runs on startup which checks if your docker version contains compose V2 and if not, fall back to using docker-compose? I would prefer to instead just have a popup that comes up after they've updated to the latest lazydocker which says if they're still using docker-compose they should update the config to use that, or instead update their docker binary to the latest version.

Contributor guide

Research direction
Update all references of 'docker compose' to 'docker compose' in code and configuration files. Then update the configuration documentation to explain how to revert to 'docker compose' if needed. Optionally, add startup logic to detect Docker Compose version and prompt users to update their config.
Tech stack
go
Domain
devops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80