kevva/to-ico

Chokes on 512x512px image

Open

#13 opened on Nov 11, 2016

View on GitHub
 (6 comments) (2 reactions) (0 assignees)JavaScript (18 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (137 stars)
PR merge metrics
 (PR metrics pending)

Description

If it can't downscale, it should fail with a user friendly exception ("Images larger than 256x256 px are not supported").

$ file icon_512x512.png 
icon_512x512.png: PNG image data, 512 x 512, 8-bit/color RGBA, non-interlaced

$ node_modules/.bin/to-ico icon_512x512.png 
TypeError: "value" argument is out of bounds
    at checkInt (buffer.js:1040:11)
    at Buffer.writeUInt8 (buffer.js:1088:5)
    at createDirectory (node_modules/to-ico/index.js:32:6)
    at Promise.all.then.data (node_modules/to-ico/index.js:98:16)
    at process._tickCallback (internal/process/next_tick.js:103:7)

$ npm list | grep to-ico
└─┬ to-ico-cli@1.0.0
  └─┬ to-ico@1.1.3

Contributor guide

Research direction
Inspect the index.js file in the to ico module to add input validation for image dimensions and throw a user friendly error message when the image is larger than 256x256 pixels.
Tech stack
javascript
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70