kevva/url-regex

Decode error

Open

#32 opened on Nov 22, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (66 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (354 stars)
PR merge metrics
 (PR metrics pending)

Description

The presence of ).{% trailing a valid URL (e.g. http://cnn.com/).{%) causes the error:

[PATH]/node_modules/normalize-url/index.js:82
		urlObj.pathname = decodeURI(urlObj.pathname);
		                  ^

URIError: URI malformed
    at decodeURI (native)
    at module.exports ([PATH]/node_modules/normalize-url/index.js:82:21)
    at [PATH]/node_modules/get-urls/index.js:14:10
    at Array.map (native)
    at module.exports ([PATH]/node_modules/get-urls/index.js:13:24)
    at [PATH]/index.js:17:16
    at Array.forEach (native)
    at [PATH]/index.js:15:9
    at [PATH]/node_modules/recursive-readdir/index.js:64:22
    at [PATH]/node_modules/recursive-readdir/index.js:64:22

Contributor guide

Research direction
Investigate the URL regex pattern in the repository to understand why trailing characters like ').{%' cause a malformed URI error when decodeURI is called. Focus on how the regex extracts URLs and how the extracted URL is passed to normalize url.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptRegular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65