keystonejs/keystone-classic

Keystone deletes keys that have a function as a value when setting options for TinyMCE

Open

#3,728 opened on Nov 23, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Steps to reproduce the behavior

  1. Install an external plugin like tinyvision
  2. Configure Keystone to use it. The relevant configuration might look like this:
keystone.init({
    // ...
    'wysiwyg additional options': {
        external_plugins: {
            tinyvision: '/admin/js/lib/tinymce/plugins/tinyvision/plugin.min.js'
        },
        tinyvision: {
            source: '/api/assets',
            upload: function() {}
        }
    }
});
  1. Create a route to intercept the request and load the plugin. The approach has been described in this comment.
  2. Inspect the options passed to the plugin

Expected behavior

All the options should be passed

Actual behavior

Options that have a function as a value are deleted. To confirm this, try to set the value of upload to a number or a string and it'll be present.

Contributor guide

Research direction
Inspect the Keystone codebase, specifically the handling of 'wysiwyg additional options' configuration to identify where function valued keys are stripped before being passed to TinyMCE.
Tech stack
javascriptnodejs
Domain
backendfull stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsKeystone basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60