keystonejs/keystone-classic

Add Access-Control-Allow-Credentials header to cors middleware

Open

#4,380 opened on Jul 5, 2017

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (2,288 forks)batch import
help wantedsecurity

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Add Access-Control-Allow-Credentials header to cors middleware.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Credentials

Contributor guide

Research direction
Add the Access Control Allow Credentials header to the CORS middleware by modifying the response headers in the existing middleware function. Refer to the MDN documentation for correct usage.
Tech stack
javascriptnodejsexpress
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsHTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75