knative/eventing

Merge TLS and OIDC e2e tests

Open

#7,638 opened on Jan 29, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (632 forks)auto 404
help wantedkind/cleanuptriage/accepted

Repository metrics

Stars
 (1,551 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently the TLS and OIDC e2e tests are mostly redundant and test the same (e.g. both have test to test the reply & DLS). Mostly the only difference is, that the OIDC tests configure an audience.

Therefor we should check, which OIDC and TLS tests can be merged and merge both "suites" together.

Hint:

  • Some tests still might be only relevant for TLS or OIDC (e.g. TestBrokerSupportsOIDC which tests only for OIDC compliance)

Contributor guide

Research direction
Identify the overlapping tests between TLS and OIDC e2e test suites and merge them while keeping unique tests separate.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70