kubernetes-sigs/aws-fsx-csi-driver

Support running e2e test on EKS

Open

#206 opened on Sep 14, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (99 forks)auto 404
help wantedkind/buglifecycle/frozen

Repository metrics

Stars
 (143 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind bug

What happened? The test fails because it tries to determine what security group to create the FSx file system in using kops-specific ec2 instance tags . https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/cloud.go#L46 The test should also check for EKS tags like https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/test/e2e/cloud.go#L215

https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/test/e2e/cloud.go#L215

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:

Contributor guide

Research direction
Add support for EKS tags in the security group detection logic in tests/e2e/cloud.go, similar to the pattern in aws efs csi driver.
Tech stack
go
Domain
testingcloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65