kubernetes-sigs/cluster-api-provider-aws

Support a list of instance types in AWSManagedMachinePool

Open

#3,585 opened on Jul 12, 2022

View on GitHub
 (23 comments) (0 reactions) (1 assignee)Go (689 forks)auto 404
area/provider/ekshelp wantedkind/featureneeds-triagepriority/important-longterm

Repository metrics

Stars
 (723 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind feature

Describe the solution you'd like AWSManagedMachinePool has a field, instanceType, for specifying a single instance type. We should support a list of instance types that the underlying node group should use.

This is primarily useful for spec.capacityType: spot, where specifying a set of instances increases your odds of finding an adequate instance, but there's nothing stopping you from using it with spec.capacityType: onDemand. More here https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html#managed-node-group-capacity-types

See eks: allow specifying multiple instance types for AWSManagedMachinePool for the initial discussion. Thanks @jashandeep-sohi for starting this!

Anything else you would like to add: The implementation should wait for a launch template support for AWSManagedMachinePool.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Contributor guide