kubernetes-sigs/cluster-api-provider-vsphere

No test verifies VMs are created as linked clone

Open

#1,765 opened on Feb 2, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (320 forks)auto 404
area/govmomihelp wantedkind/feature

Repository metrics

Stars
 (417 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind feature

Describe the solution you'd like

An E2E test verifying linked clone should be added.

When spec.cloneMode of VSphereMachine resource is specified to linkedClone, a corresponding virtual machine has to be created by using linked clone. But there is no test that verifies this behavior, so it could breaks without you noticing. For instance, #1611 reported such a bug.

Anything else you would like to add:

Environment:

Contributor guide

Research direction
Study existing E2E tests for cloning VMs, then implement a test that verifies linked clone creation when spec.cloneMode is set to linkedClone.
Tech stack
go
Domain
backendcloud
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetesvSphere
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40