kubernetes-sigs/cluster-api-provider-vsphere

Use generics for functions used in controller-runtime's builders

Open

#3,150 opened on Aug 12, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (320 forks)auto 404
area/govmomiarea/supervisorhelp wantedkind/cleanup

Repository metrics

Stars
 (417 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind cleanup /help

Describe the solution you'd like [A clear and concise description of what you want to happen.]

When using the builder from cotnroller runtime (Setup functions for AddToManager) we should migrate to use generics.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Follow-up from https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/3146#discussion_r1713598349

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Contributor guide

Research direction
Examine the current Setup functions in the codebase that use controller runtime builders, and identify where generics can be introduced. Refer to the discussion in PR #3146 for examples.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60