kubernetes-sigs/cluster-api-provider-vsphere

Set InternalIP machine status.addresses

Open

#947 opened on Jul 1, 2020

View on GitHub
 (11 comments) (1 reaction) (0 assignees)Go (320 forks)auto 404
help wantedkind/buglifecycle/frozenpriority/important-soon

Repository metrics

Stars
 (417 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind feature

Describe the solution you'd like Almost always a VM will have an address internal to the datacenter. In the case where we don't know if an address is external or internal to the datacenter, we should assume it is internal and set the type as InternalIP. Today we always set it as an ExternalIP

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Contributor guide

Research direction
Modify the logic that assigns IP addresses to machine status addresses. Currently, all discovered addresses are set as ExternalIP. Change it so that addresses internal to the datacenter (or when unknown) are set as InternalIP. Look for the function that sets the node addresses and update the type based on the network context.
Tech stack
go
Domain
backendapiinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
gokubernetescluster api
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60